Re: [PATCH 0/3] LoongArch: Fix build errors

From: Huacai Chen
Date: Fri Jul 01 2022 - 23:35:21 EST


Hi, Guenter,

On Fri, Jul 1, 2022 at 10:49 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> A number of build errors is seen when trying to build loongarch:allnoconfig
> or loongarch:tinyconfig. This patch series tries to fix the observed
> errors.
Thank you very much for your patches. From my point of view, the first
patch is good, but we usually include <linux/xxx> before <asm/yyy>;
the second patch is not so good, and I think the correct way is modify
the cflags for vdso [1]; and the third patch can be dropped at this
time, until our kernel is bootable.

[1] https://lore.kernel.org/loongarch/20220623044715.2072428-1-chenhuacai@xxxxxxxxxxx/T/#u

Huacai
>
> ----------------------------------------------------------------
> Guenter Roeck (3):
> LoongArch: page.h: Add missing include file
> LoongArch: Do not include file from toolchain
> LoongArch: Always select EFI
>
> arch/loongarch/Kconfig | 6 ++----
> arch/loongarch/include/asm/loongarch.h | 23 +++++++++++------------
> arch/loongarch/include/asm/page.h | 1 +
> 3 files changed, 14 insertions(+), 16 deletions(-)