Re: [PATCH v2 4/6] leds: is31fl319x: Use non-wildcard names for vars, structs and defines

From: Andy Shevchenko
Date: Fri Jul 01 2022 - 16:50:03 EST


On Fri, Jul 1, 2022 at 10:47 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Jul 1, 2022 at 3:45 PM Vincent Knecht <vincent.knecht@xxxxxxxxxx> wrote:

...

> > +#define IS31FL3196_CURRENT_MIN ((u32)5000)
> > +#define IS31FL3196_CURRENT_MAX ((u32)40000)
> > +#define IS31FL3196_CURRENT_STEP ((u32)5000)
> > +#define IS31FL3196_CURRENT_DEFAULT ((u32)20000)

Also why no units as below, for example, has?

> > +#define IS31FL3196_AUDIO_GAIN_DB_MAX ((u32)21)
> > +#define IS31FL3196_AUDIO_GAIN_DB_STEP ((u32)3)

--
With Best Regards,
Andy Shevchenko