Re: [PATCH 1/4] arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998

[Caleb Connolly]

On 05/05/2022 03:27, Bjorn Andersson wrote:
> Add PWM/LPG nodes to the PMICs currently supported by the binding.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
fwiw:
Reviewed-by: Caleb Connolly <caleb@xxxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/pm8916.dtsi  |  8 ++++++++
>   arch/arm64/boot/dts/qcom/pm8994.dtsi  | 10 ++++++++++
>   arch/arm64/boot/dts/qcom/pmi8994.dtsi | 10 ++++++++++
>   arch/arm64/boot/dts/qcom/pmi8998.dtsi | 11 ++++++++++-
>   4 files changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> index d58902432812..99bf8387bfb6 100644
> --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> @@ -125,6 +125,14 @@ pm8916_1: pmic@1 {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>
> +		pm8916_pwm: pwm {
> +			compatible = "qcom,pm8916-pwm";
> +
> +			#pwm-cells = <2>;
> +
> +			status = "disabled";
> +		};
> +
>   		pm8916_vib: vibrator@c000 {
>   			compatible = "qcom,pm8916-vib";
>   			reg = <0xc000>;
> diff --git a/arch/arm64/boot/dts/qcom/pm8994.dtsi b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> index 5ab46117d737..ab342397fcd8 100644
> --- a/arch/arm64/boot/dts/qcom/pm8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8994.dtsi
> @@ -135,6 +135,16 @@ pmic@1 {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>
> +		pm8994_lpg: lpg {
> +			compatible = "qcom,pm8994-lpg";
> +
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#pwm-cells = <2>;
> +
> +			status = "disabled";
> +		};
> +
>   		pm8994_spmi_regulators: regulators {
>   			compatible = "qcom,pm8994-regulators";
>   		};
> diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> index 6e7c252568e6..b1b50c99ada2 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
> @@ -27,6 +27,16 @@ pmic@3 {
>   		#address-cells = <1>;
>   		#size-cells = <0>;
>
> +		pmi8994_lpg: lpg {
> +			compatible = "qcom,pmi8994-lpg";
> +
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#pwm-cells = <2>;
> +
> +			status = "disabled";
> +		};
> +
>   		pmi8994_spmi_regulators: regulators {
>   			compatible = "qcom,pmi8994-regulators";
>   			#address-cells = <1>;
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index 0fef5f113f05..7af106683f8d 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -42,6 +42,16 @@ lab: lab {
>   			};
>   		};
>
> +		pmi8998_lpg: lpg {
> +			compatible = "qcom,pmi8998-lpg";
> +
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			#pwm-cells = <2>;
> +
> +			status = "disabled";
> +		};
> +
>   		pmi8998_wled: leds@d800 {
>   			compatible = "qcom,pmi8998-wled";
>   			reg = <0xd800 0xd900>;
> @@ -52,6 +62,5 @@ pmi8998_wled: leds@d800 {
>
>   			status = "disabled";
>   		};
> -
>   	};
>   };
> --
> 2.35.1
>

--
Kind Regards,
Caleb