Re: [PATCH v4 3/5] dt-bindings: arm: msm: Rework kpss-gcc driver Documentation to yaml

From: Rob Herring
Date: Fri Jul 01 2022 - 13:32:48 EST


On Wed, Jun 29, 2022 at 02:14:39PM +0200, Christian Marangi wrote:
> Rework kpss-gcc driver Documentation to yaml Documentation.

It's not 'driver Documentation'. It's a DT binding for h/w.

Lot's of things are YAML. I prefer 'DT schema'

The subjects are bit long and get cut off as well. For the subject,
something like:

dt-bindings: arm: msm: Convert kpss-gcc to DT schema

And similar for the other patch.

> The current kpss-gcc Documentation have major problems and can't be
> converted directly. Introduce various changes to the original
> Documentation.
>
> Add #clock-cells additional binding as this clock outputs a static clk
> named acpu_l2_aux with supported compatible.
> Only some compatible require and outputs a clock, for the others, set
> only the reg as a required binding to correctly export the kpss-gcc
> registers. As the reg is shared also add the required syscon compatible.
>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> ---
> .../bindings/arm/msm/qcom,kpss-gcc.txt | 44 ---------
> .../bindings/arm/msm/qcom,kpss-gcc.yaml | 90 +++++++++++++++++++
> 2 files changed, 90 insertions(+), 44 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.txt
> create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,kpss-gcc.yaml