Re: [PATCH] arm64: dta: qcom: sc7180: delete vdda-1p2 and vdda-0p9 from mdss_dp

From: Doug Anderson
Date: Fri Jul 01 2022 - 12:13:28 EST


Hi,

On Fri, Jul 1, 2022 at 8:47 AM Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx> wrote:
>
> Both vdda-1p2-supply and vdda-0p9-supply regulators are controlled
> by dp combo phy. Therefore remove them from dp controller.
>
> Signed-off-by: Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 732e118..824a98c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -813,8 +813,6 @@ hp_i2c: &i2c9 {
> pinctrl-names = "default";
> pinctrl-0 = <&dp_hot_plug_det>;
> data-lanes = <0 1>;
> - vdda-1p2-supply = <&vdda_usb_ss_dp_1p2>;
> - vdda-0p9-supply = <&vdda_usb_ss_dp_core>;
> };

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

NOTE: this is somewhat related to Kuogee's series [1] but it's OK to
take even though his series hasn't landed. On trogdor we always keep
these regulators in HPM mode so we're not truly dependent on the
addition of regulator_set_load in the DP PHY.

[1] https://lore.kernel.org/lkml/8b751eb3-2e19-0e03-4c94-b26b3badd397@xxxxxxxxxx/

-Doug