Re: [PATCH v4 1/9] tty: n_gsm: fix user open not possible at responder until initiator open

[Greg KH]

On Fri, Jul 01, 2022 at 08:16:44AM +0200, D. Starke wrote:
> From: Daniel Starke <daniel.starke@xxxxxxxxxxx>
> 
> After setting up the control channel on both sides the responder side may
> want to open a virtual tty to listen on until the initiator starts an
> application on a user channel. The current implementation allows the
> open() but no other operation, like termios. These fail with EINVAL.
> The responder sided application has no means to detect an open by the
> initiator sided application this way. And the initiator sided applications
> usually expect the responder sided application to listen on the user
> channel upon open.
> Set the user channel into half-open state on responder side once a user
> application opens the virtual tty to allow IO operations on it.
> Furthermore, keep the user channel constipated until the initiator side
> opens it to give the responder sided application the chance to detect the
> new connection and to avoid data loss if the responder sided application
> starts sending before the user channel is open.
> 
> Fixes: e1eaea46bb40 ("tty: n_gsm line discipline")
> Signed-off-by: Daniel Starke <daniel.starke@xxxxxxxxxxx>
> ---
>  drivers/tty/n_gsm.c | 31 +++++++++++++++++++++++++++++--
>  1 file changed, 29 insertions(+), 2 deletions(-)
> 
> Stable backport remark has been removed compared to v3. No other changes applied.
> 
> Link: https://lore.kernel.org/all/20220530144512.2731-1-daniel.starke@xxxxxxxxxxx/

Not all patches in this series would apply to my tree.  Please rebase
the remaining ones and resend.

thanks,

greg k-h