Re: [PATCH v1 2/2] iio: accel: bma400: Add support for single and double tap events

[Andy Shevchenko]

On Mon, Jun 13, 2022 at 9:17 PM Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote:
>
> Add support for single and double tap events based on the tap threshold
> value and minimum quiet time value between the taps. The INT1 pin is used
> to interrupt and event is pushed to userspace.

the event

...

>  #include <linux/iio/trigger.h>
>  #include <linux/iio/trigger_consumer.h>
>  #include <linux/iio/triggered_buffer.h>
> +#include <linux/iio/sysfs.h>

s is before t

...

>         bool step_event_en;
>         bool activity_event_en;
>         unsigned int generic_event_en;
> +       unsigned int tap_event_en;

Should it be boolean? Or i.o.w. why does it need to be an unsigned int?

...

> +       data->step_event_en = 0;
> +       data->activity_event_en = 0;

These are booleans.

-- 
With Best Regards,
Andy Shevchenko