Re: [PATCH] spi: micro: fix unreasonable clk_prepare_enable() on error in mchp_corespi_probe()

[Conor.Dooley]

On 11/06/2022 03:11, Peng Wu wrote:
> spi: micro: fix unreasonable clk_prepare_enable() on error in mchp_corespi_probe()

       ^ s/micro/microchip-core ?

> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Fix the unreasonable clk_prepare_enable() with clk_disable_unprepare()
> before return from mchp_corespi_probe() in the error handling case.
> 
> Signed-off-by: Peng Wu <wupeng58@xxxxxxxxxx>

"unreasonable", very diplomatic way of putting it!

Good spot, thanks.
Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

> ---
>  drivers/spi/spi-microchip-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index 5b2aee30fa04..bf6847d95fe3 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -580,7 +580,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
> 
>  error_release_hardware:
>         mchp_corespi_disable(spi);
> -       clk_prepare_enable(spi->clk);
> +       clk_disable_unprepare(spi->clk);
>  error_release_master:
>         spi_master_put(master);
> 
> --
> 2.17.1
>