Re: [PATCH v3 8/8] dt-bindings: pinctrl: samsung: deprecate header with register constants

From: Krzysztof Kozlowski
Date: Sun Jun 05 2022 - 12:07:17 EST


On 05/06/2022 18:05, Krzysztof Kozlowski wrote:
> For convenience (less code duplication, some meaning added to raw
> number), the pin controller pin configuration register values
> were defined in the bindings header. These are not some IDs or other
> abstraction layer but raw numbers used in the registers
>
> These constants do not fit the purpose of bindings. They do not provide
> any abstraction, any hardware and driver independent ID. With minor
> exceptions, the Linux drivers actually do not use the bindings header at
> all.
>
> All of the constants were moved already to headers local to DTS
> (residing in DTS directory) and to Samsung pinctrl driver (where
> applicable), so remove any references to the bindings header and add a
> warning tha tit is deprecated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Reviewed-by: Chanho Park <chanho61.park@xxxxxxxxxxx>
> Reviewed-by: Linus Walleij <linus.wallej@xxxxxxxxxx>

This needs fixup in address ^^^^.

Best regards,
Krzysztof