Re: [PATCH] perf c2c: Fix sorting in percent_rmt_hitm_cmp()

[Namhyung Kim]

On Mon, May 30, 2022 at 1:43 AM Leo Yan <leo.yan@xxxxxxxxxx> wrote:
>
> The function percent_rmt_hitm_cmp() wrongly uses local HITMs for
> sorting remote HITMs.
>
> Since this function is to sort cache lines for remote HITMs, this patch
> changes to use 'rmt_hitm' field for correct sorting.
>
> Fixes: 9cb3500afc09 ("perf c2c report: Add hitm/store percent related sort keys")
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung


> ---
>  tools/perf/builtin-c2c.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c
> index c8230c48125f..e8280973d7b8 100644
> --- a/tools/perf/builtin-c2c.c
> +++ b/tools/perf/builtin-c2c.c
> @@ -928,8 +928,8 @@ percent_rmt_hitm_cmp(struct perf_hpp_fmt *fmt __maybe_unused,
>         double per_left;
>         double per_right;
>
> -       per_left  = PERCENT(left, lcl_hitm);
> -       per_right = PERCENT(right, lcl_hitm);
> +       per_left  = PERCENT(left, rmt_hitm);
> +       per_right = PERCENT(right, rmt_hitm);
>
>         return per_left - per_right;
>  }
> --
> 2.25.1
>