Re: [PATCH v3 3/3] squashfs: implement readahead

[Andrew Morton]

On Tue, 31 May 2022 17:51:11 +0800 Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:

> On Mon, May 23, 2022 at 3:00 PM Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> wrote:
> >
> > Implement readahead callback for squashfs. It will read datablocks
> > which cover pages in readahead request. For a few cases it will
> > not mark page as uptodate, including:
> > - file end is 0.
> > - zero filled blocks.
> > - current batch of pages isn't in the same datablock or not enough in a
> >   datablock.
> > - decompressor error.
> > Otherwise pages will be marked as uptodate. The unhandled pages will be
> > updated by readpage later.
> >
> > Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > Reported-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > Reported-by: Phillip Lougher <phillip@xxxxxxxxxxxxxxx>
> > Reported-by: Xiongwei Song <Xiongwei.Song@xxxxxxxxxxxxx>
> > ---
> 
> Kindly ping on the thread. Conversations on v2:
> https://patchwork.kernel.org/project/linux-mm/patch/20220517082650.2005840-4-hsinyi@xxxxxxxxxxxx/#24869037
> This version mainly addressed the error handling.

Yes, some reviewer input would be helpful please.