Re: [PATCH v3 0/4] KVM: s390: selftests: Provide TAP output in tests

From: Christian Borntraeger
Date: Tue May 31 2022 - 05:07:21 EST




Am 31.05.22 um 10:02 schrieb Thomas Huth:
On 29/04/2022 08.37, Thomas Huth wrote:
This patch series is motivated by Shuah's suggestion here:

  https://lore.kernel.org/kvm/d576d8f7-980f-3bc6-87ad-5a6ae45609b8@xxxxxxxxxxxxxxxxxxx/

Many s390x KVM selftests do not output any information about which
tests have been run, so it's hard to say whether a test binary
contains a certain sub-test or not. To improve this situation let's
add some TAP output via the kselftest.h interface to these tests,
so that it easier to understand what has been executed or not.

v3:
  - Added comments / fixed cosmetics according to Janosch's and
    Janis' reviews of the v2 series
  - Added Reviewed-by tags from the v2 series

v2:
  - Reworked the extension checking in the first patch
  - Make sure to always print the TAP 13 header in the second patch
  - Reworked the SKIP printing in the third patch

Thomas Huth (4):
   KVM: s390: selftests: Use TAP interface in the memop test
   KVM: s390: selftests: Use TAP interface in the sync_regs test
   KVM: s390: selftests: Use TAP interface in the tprot test
   KVM: s390: selftests: Use TAP interface in the reset test

  tools/testing/selftests/kvm/s390x/memop.c     | 90 +++++++++++++++----
  tools/testing/selftests/kvm/s390x/resets.c    | 38 ++++++--
  .../selftests/kvm/s390x/sync_regs_test.c      | 87 +++++++++++++-----
  tools/testing/selftests/kvm/s390x/tprot.c     | 29 ++++--
  4 files changed, 193 insertions(+), 51 deletions(-)

Can you refresh against latest linus master? I will apply then