Re: [PATCH v3 0/2] Fix some compile warnings in v5.18+

From: Phillip Potter
Date: Tue May 31 2022 - 02:40:36 EST


On Mon, May 30, 2022 at 08:31:01PM -0500, Larry Finger wrote:
> Building driver r8188eu in staging with -warray-bounds exposes two places
> where arrays are too small.
>
> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> ---
> v2 - get proper To and Cc
> v3 - Use Dan Carpenter's suggestion for correct patch.
>
> Larry Finger (2):
> staging: r8188eu: Fix undersized array in rtw_xmit.c
> staging: r8188eu: Fix warning of array overflow in ioctl_linux.c
>
> drivers/staging/r8188eu/core/rtw_xmit.c | 17 ++++-------------
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +-
> 2 files changed, 5 insertions(+), 14 deletions(-)
>
> --
> 2.36.1
>

Hi Larry,

Both patches look good to me, however I've already submitted a patch 10
days ago that does exactly what your rtw_xmit.c patch does, in
addition to fixing the changed error handling semantics for the relevant
function (in f94b47c6bde6) which broke the driver.

Regards,
Phil