Re: [PATCH] workqueue: missing NOT while checking if Workqueue is offline

From: Geraldo Nascimento
Date: Tue May 31 2022 - 00:13:16 EST


On Sat, May 28, 2022 at 08:14:23PM -1000, Tejun Heo wrote:
> Yeah, you're wrong.

Hi Tejun,

you were completely right about me being wrong. It's a real shame to me
and I am only asking for an apology in case there were any doubts.

With my "patch" I was unable to cancel service on the GPU ("sending
SIGINT to MPV because I like to Ctrl+C") at the same time as running
ROCm inference on the AMD Renoir APU with amdkfd of amdgpu.

My machine froze beyond expectation of recovery, I would like to see
what e.g. netconsole would report but it's irrelevant, it would case a
major regression in the kernel tree if this was ever introduced.

Sorry for the misunderstanding, I guess it's the burden of maintaning,
too. My deepest apologies.

I'll follow your advice and try to be more careful and detailed without
mixing what I know and what I don't next time.

Many thanks,
Geraldo Nascimento