Re: [PATCH 2/3] mm/swapfile: avoid confusing swap cache statistics

From: Andrew Morton
Date: Mon May 30 2022 - 19:04:25 EST


On Fri, 27 May 2022 17:26:25 +0800 Miaohe Lin <linmiaohe@xxxxxxxxxx> wrote:

> At swapoff time, we're going to swap in the pages continuously. So calling
> lookup_swap_cache would confuse statistics. We should use find_get_page
> directly here.

Why is the existing behaviour wrong? swapoff() has to swap stuff in to
be able to release the swap device. Why do you believe that this
swapin activity should not be accounted?