Re: [PATCH v2 0/5] iio: treewide: rearrange iio trig get/register

From: Dmitry Rokosov
Date: Mon May 30 2022 - 11:54:18 EST


Jonathan,

On Sat, May 28, 2022 at 06:10:04PM +0100, Jonathan Cameron wrote:
> > If this call order is wrong, the next iio_trigger_put() (from sysfs
> > callback or "delete module" path) will dereference "default" module
> > refcnt, which is incorrect behaviour.
>
> Hi Dmitry,
>
> Series applied to the fixes-togreg branch of iio.git and marked for stable.
>

Thank you!

> Do you think it's also worth adding a runtime warning in iio_trigger_get()
> on !trig->owner so that we catch any cases of this introduced in the future?
>

Good point, it will help other kernel developers to avoid such mistake.
I'll prepare new patchset with that.

--
Thank you,
Dmitry