Re: [PATCH -next] cpufreq: CPPC: Fix build error without CONFIG_ACPI_CPPC_CPUFREQ_FIE

From: Rafael J. Wysocki
Date: Mon May 30 2022 - 09:51:44 EST


On Mon, May 23, 2022 at 8:58 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> On 21-05-22, 11:24, Zheng Bin wrote:
> > If CONFIG_ACPI_CPPC_CPUFREQ_FIE is not set, building fails:
> >
> > drivers/cpufreq/cppc_cpufreq.c: In function ‘populate_efficiency_class’:
> > drivers/cpufreq/cppc_cpufreq.c:584:2: error: ‘cppc_cpufreq_driver’ undeclared (first use in this function); did you mean ‘cpufreq_driver’?
> > cppc_cpufreq_driver.register_em = cppc_cpufreq_register_em;
> > ^~~~~~~~~~~~~~~~~~~
> > cpufreq_driver
> >
> > Make declare of cppc_cpufreq_driver out of CONFIG_ACPI_CPPC_CPUFREQ_FIE
> > to fix this.
> >
> > Fixes: 740fcdc2c20e ("cpufreq: CPPC: Register EM based on efficiency class information")
> > Signed-off-by: Zheng Bin <zhengbin13@xxxxxxxxxx>
> > ---
> > drivers/cpufreq/cppc_cpufreq.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Applied, thanks!