Re: [PATCH v4 16/17] ALSA: hda: cs35l41: Support Firmware switching and reloading

[Jaroslav Kysela]

On 25. 05. 22 15:16, Vitaly Rodionov wrote:

> This patch adds 2 ALSA Controls for each amp:
> "DSP1 Firmware Load"
> "DSP1 Firmware Type"

...

> +	struct snd_kcontrol_new fw_type_ctl = {
> +		.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> +		.info = cs35l41_fw_type_ctl_info,
> +		.get = cs35l41_fw_type_ctl_get,
> +		.put = cs35l41_fw_type_ctl_put,
> +	};
> +	struct snd_kcontrol_new fw_load_ctl = {
> +		.iface = SNDRV_CTL_ELEM_IFACE_MIXER,
> +		.info = snd_ctl_boolean_mono_info,
> +		.get = cs35l41_fw_load_ctl_get,
> +		.put = cs35l41_fw_load_ctl_put,
> +	};

I don't think that those controls should be SNDRV_CTL_ELEM_IFACE_MIXER type. 
The SNDRV_CTL_ELEM_IFACE_CARD seems more appropriate (service controls for the 
sound card).

						Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.