Re: [RFC 2/2] iio: accel: bma400: Add support for single and double tap events

[Andy Shevchenko]

On Sun, May 29, 2022 at 6:02 AM Jagath Jog J <jagathjog1996@xxxxxxxxx> wrote:
>
> Add support for single and double tap events based on the tap threshold
> value and minimum quite time value between the taps. INT1 pin is used to

quiet (see below as well)

The INT1

> interrupt and event is pushed to userspace.

an event

...

> +#define BMA400_TAP_QUITE_MSK        GENMASK(3, 2)

QUIET ?

...

> +       /*
> +        * No need to change ODR when tap event is enabled because
> +        * tap interrupt is operating with the data rate of 200Hz.
> +        * See datasheet page 124.

When referring to the datasheet, please be more specific, i.e. table /
chart / section number and name, No page needed as it may  be changed
from version to version, also date of the document or revision would
be nice to add.

> +        */

-- 
With Best Regards,
Andy Shevchenko