Re: [PATCH v10 04/19] KVM: s390: pv: refactor s390_reset_acc

From: Nico Boehr
Date: Mon May 30 2022 - 03:41:01 EST


On Mon, 2022-05-16 at 18:11 +0200, Claudio Imbrenda wrote:
[...]
> > [...]
> > > diff --git a/arch/s390/mm/gmap.c b/arch/s390/mm/gmap.c
> > > index e8904cb9dc38..a3a1f90f6ec1 100644
> > > --- a/arch/s390/mm/gmap.c
> > > +++ b/arch/s390/mm/gmap.c
> > > @@ -2676,44 +2676,81 @@ void s390_reset_cmma(struct mm_struct
> > > *mm)
> > >  }
> > >  EXPORT_SYMBOL_GPL(s390_reset_cmma);
> > >  
> > > -/*
> > > - * make inaccessible pages accessible again
> > > - */
> > > -static int __s390_reset_acc(pte_t *ptep, unsigned long addr,
> > > -                           unsigned long next, struct mm_walk
> > > *walk)
> > > +#define DESTROY_LOOP_THRESHOLD 32 
> >
> > maybe GATHER_NUM_PAGE_REFS_TO_TAKE?
>
> what about GATHER_GET_PAGES ?

Yes, that's good as well.