RE: [PATCH crypto v2] crypto: blake2s - remove shash module

[David Laight]

From: Eric Biggers
> Sent: 28 May 2022 18:20
> 
> On Sat, May 28, 2022 at 11:57:01AM +0200, Jason A. Donenfeld wrote:
> > > Also, the wrong value is being passed for the 'inc' argument.
> >
> > Are you sure? Not sure I'm seeing what you are on first glance.
> 
> Yes, 'inc' is the increment amount per block.  It needs to always be
> BLAKE2S_BLOCK_SIZE unless a partial block is being processed.

IIRC it isn't used for partial blocks.
Which rather begs the question as to why it is a parameter at all.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)