RE: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before the configuration data

[Ming Qian]

> From: Nicolas Dufresne <nicolas@xxxxxxxxxxxx>
> Sent: 2022年5月28日 3:26
> To: Ming Qian <ming.qian@xxxxxxx>; Fabio Estevam <festevam@xxxxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Mirela Rabulea (OSS)
> <mirela.rabulea@xxxxxxxxxxx>; Hans Verkuil <hverkuil-cisco@xxxxxxxxx>;
> Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>;
> Sascha Hauer <kernel@xxxxxxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-media <linux-media@xxxxxxxxxxxxxxx>; linux-kernel
> <linux-kernel@xxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED
> DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; moderated
> list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> Subject: Re: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space before
> the configuration data
> 
> Caution: EXT Email
> 
> Le vendredi 27 mai 2022 à 11:33 +0000, Ming Qian a écrit :
> > > From: Fabio Estevam <festevam@xxxxxxxxx>
> > > Sent: 2022年5月27日 19:12
> > > To: Ming Qian <ming.qian@xxxxxxx>
> > > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>; Mirela Rabulea (OSS)
> > > <mirela.rabulea@xxxxxxxxxxx>; Hans Verkuil
> > > <hverkuil-cisco@xxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha
> > > Hauer <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer
> > > <kernel@xxxxxxxxxxxxxx>; dl-linux-imx <linux-imx@xxxxxxx>;
> > > linux-media <linux-media@xxxxxxxxxxxxxxx>; linux-kernel
> > > <linux-kernel@xxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND
> > > FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>;
> > > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
> > > <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>
> > > Subject: [EXT] Re: [PATCH v2] media: imx-jpeg: Leave a blank space
> > > before the configuration data
> > >
> > > Caution: EXT Email
> > >
> > > Hi Ming,
> > >
> > > On Fri, May 27, 2022 at 7:25 AM Ming Qian <ming.qian@xxxxxxx> wrote:
> > > >
> > > > There is a hardware bug that it will load the first 128 bytes of
> > > > configuration data twice, it will led to some configure error.
> > > > so shift the configuration data 128 bytes, and make the first 128
> > > > bytes all zero, then hardware will load the 128 zero twice, and
> > > > ignore them as garbage.
> > > > then the configuration data can be loaded correctly
> > > >
> > > > Signed-off-by: Ming Qian <ming.qian@xxxxxxx>
> > > > Reviewed-by: Mirela Rabulea <mirela.rabulea@xxxxxxx>
> > > > Reviewed-by: Tommaso Merciai
> > > > <tommaso.merciai@xxxxxxxxxxxxxxxxxxxx>
> > >
> > > Fixes tag?
> >
> > Hi Fabio,
> >     It's a hardware issue, so I'm not sure is it a driver issue that I fix it.
> >     Or I just check which patch includes the code I changed, and add
> > the fix tag?
> 
> You can use Fixes tag even though there was no software bug. The point of the
> tag is to help locate how far we can backport this patch in order to let stable
> kernel users benefit.
> 
> regards,
> Nicolas
> 

Hi Nicolas,
    Thanks for your information, I'll add a fix tag in v3.
Ming.

> >
> > Ming