Re: [PATCH crypto v2] crypto: blake2s - remove shash module

From: Jason A. Donenfeld
Date: Sat May 28 2022 - 15:57:34 EST


On Sat, May 28, 2022 at 7:19 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Sat, May 28, 2022 at 11:57:01AM +0200, Jason A. Donenfeld wrote:
> > > Also, the wrong value is being passed for the 'inc' argument.
> >
> > Are you sure? Not sure I'm seeing what you are on first glance.
>
> Yes, 'inc' is the increment amount per block. It needs to always be
> BLAKE2S_BLOCK_SIZE unless a partial block is being processed.

Bingo, thanks. v+1 coming up.

Jason