Re: [PATCH v5] ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to avoid adding weak function

From: Steven Rostedt
Date: Fri May 27 2022 - 23:19:14 EST


On Fri, 27 May 2022 16:32:05 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> @@ -4003,7 +4128,11 @@ ftrace_match_record(struct dyn_ftrace *rec, struct ftrace_glob *func_g,
> char str[KSYM_SYMBOL_LEN];
> char *modname;
>
> - kallsyms_lookup(rec->ip, NULL, NULL, &modname, str);
> + if (lookup_ip(rec->ip, &modname, str)) {
> + /* This should only happen when a rec is disabled */
> + WARN_ON_ONCE(!(rec->flags & FTRACE_FL_DISABLED));

It appears that some of the start up tests can call this before the
workqueue sets it to DISABLED, so we need to not WARN_ON() here. :-/

-- Steve


> + return 0;
> + }
>