[dhowells-fs:cifs-for-sfrench 5/9] fs/cifs/smb2ops.c:4754:11: warning: comparison of distinct pointer types ('typeof (size - copied) *' (aka 'unsigned int *') and 'typeof (((1UL) << (12))) *' (aka 'unsigned long *'))
From: kernel test robot
Date: Fri May 27 2022 - 16:47:25 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git cifs-for-sfrench
head: c1da8a43f0f920f86394ca254c99a91622bb3fe4
commit: 36c9de734b21b4bc60b7ee86228659d416d53470 [5/9] cifs: Change the I/O paths to use an iterator rather than a page list
config: riscv-randconfig-r002-20220524 (https://download.01.org/0day-ci/archive/20220528/202205280431.HKHuQxkz-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 134d7f9a4b97e9035150d970bd9e376043c4577e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/commit/?id=36c9de734b21b4bc60b7ee86228659d416d53470
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs cifs-for-sfrench
git checkout 36c9de734b21b4bc60b7ee86228659d416d53470
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash fs/cifs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
>> fs/cifs/smb2ops.c:4754:11: warning: comparison of distinct pointer types ('typeof (size - copied) *' (aka 'unsigned int *') and 'typeof (((1UL) << (12))) *' (aka 'unsigned long *')) [-Wcompare-distinct-pointer-types]
seg = min(size - copied, PAGE_SIZE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:45:19: note: expanded from macro 'min'
#define min(x, y) __careful_cmp(x, y, <)
^~~~~~~~~~~~~~~~~~~~~~
include/linux/minmax.h:36:24: note: expanded from macro '__careful_cmp'
__builtin_choose_expr(__safe_cmp(x, y), \
^~~~~~~~~~~~~~~~
include/linux/minmax.h:26:4: note: expanded from macro '__safe_cmp'
(__typecheck(x, y) && __no_side_effects(x, y))
^~~~~~~~~~~~~~~~~
include/linux/minmax.h:20:28: note: expanded from macro '__typecheck'
(!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~
fs/cifs/smb2ops.c:4963:7: warning: variable 'length' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
if (rdata->result != 0) {
^~~~~~~~~~~~~~~~~~
fs/cifs/smb2ops.c:4995:9: note: uninitialized use occurs here
return length;
^~~~~~
fs/cifs/smb2ops.c:4963:3: note: remove the 'if' if its condition is always true
if (rdata->result != 0) {
^~~~~~~~~~~~~~~~~~~~~~~~
fs/cifs/smb2ops.c:4862:12: note: initialize the variable 'length' to silence this warning
int length;
^
= 0
2 warnings generated.
vim +4754 fs/cifs/smb2ops.c
4704
4705 /*
4706 * This function will initialize new_rq and encrypt the content.
4707 * The first entry, new_rq[0], only contains a single iov which contains
4708 * a smb2_transform_hdr and is pre-allocated by the caller.
4709 * This function then populates new_rq[1+] with the content from olq_rq[0+].
4710 *
4711 * The end result is an array of smb_rqst structures where the first structure
4712 * only contains a single iov for the transform header which we then can pass
4713 * to crypt_message().
4714 *
4715 * new_rq[0].rq_iov[0] : smb2_transform_hdr pre-allocated by the caller
4716 * new_rq[1+].rq_iov[*] == old_rq[0+].rq_iov[*] : SMB2/3 requests
4717 */
4718 static int
4719 smb3_init_transform_rq(struct TCP_Server_Info *server, int num_rqst,
4720 struct smb_rqst *new_rq, struct smb_rqst *old_rq)
4721 {
4722 struct smb2_transform_hdr *tr_hdr = new_rq[0].rq_iov[0].iov_base;
4723 struct page *page;
4724 unsigned int orig_len = 0;
4725 int i, j;
4726 int rc = -ENOMEM;
4727
4728 for (i = 1; i < num_rqst; i++) {
4729 struct smb_rqst *old = &old_rq[i - 1];
4730 struct smb_rqst *new = &new_rq[i];
4731 struct xarray *buffer = &new->rq_buffer;
4732 unsigned int npages;
4733 size_t size = iov_iter_count(&old->rq_iter), seg, copied = 0;
4734
4735 xa_init(buffer);
4736
4737 if (size > 0) {
4738 npages = DIV_ROUND_UP(size, PAGE_SIZE);
4739 for (j = 0; j < npages; j++) {
4740 void *o;
4741
4742 rc = -ENOMEM;
4743 page = alloc_page(GFP_KERNEL|__GFP_HIGHMEM);
4744 if (!page)
4745 goto err_free;
4746 page->index = j;
4747 o = xa_store(buffer, j, page, GFP_KERNEL);
4748 if (xa_is_err(o)) {
4749 rc = xa_err(o);
4750 put_page(page);
4751 goto err_free;
4752 }
4753
> 4754 seg = min(size - copied, PAGE_SIZE);
4755 if (copy_page_from_iter(page, 0, seg, &old->rq_iter) != seg) {
4756 rc = -EFAULT;
4757 goto err_free;
4758 }
4759 copied += seg;
4760 }
4761 iov_iter_xarray(&new->rq_iter, iov_iter_rw(&old->rq_iter),
4762 buffer, 0, size);
4763 }
4764 new->rq_iov = old->rq_iov;
4765 new->rq_nvec = old->rq_nvec;
4766 orig_len += smb_rqst_len(server, new);
4767 }
4768
4769 /* fill the 1st iov with a transform header */
4770 fill_transform_hdr(tr_hdr, orig_len, old_rq, server->cipher_type);
4771
4772 rc = crypt_message(server, num_rqst, new_rq, 1);
4773 cifs_dbg(FYI, "Encrypt message returned %d\n", rc);
4774 if (rc)
4775 goto err_free;
4776
4777 return rc;
4778
4779 err_free:
4780 smb3_free_compound_rqst(num_rqst - 1, &new_rq[1]);
4781 return rc;
4782 }
4783
--
0-DAY CI Kernel Test Service
https://01.org/lkp