Re: [PATCH] rcu: Cleanup RCU urgency state for offline CPU

From: Paul E. McKenney
Date: Fri May 27 2022 - 13:10:13 EST


On Thu, May 26, 2022 at 09:55:12AM +0800, Zqiang wrote:
> When an RCU grace period starts and at this time the CPU is in
> the process of going offline, if the RCU gp-fqs occurs during the
> time period when the CPU has passed the stop-machine but has not
> yet entered the idle loop, and this CPU have not report quiescent
> state yet, its urgent flags maybe is set, for example due to cbovld
> is true, but this CPUs rcu urgent flags is not cleanup in rcu_report_dead()
> when report qs. however for CPU that have been report qs, its rcu
> urgent flags should cleanup, so add rcu_disable_urgency_upon_qs()
> in rcu_report_dead() when CPU report qs.
>
> Signed-off-by: Zqiang <qiang1.zhang@xxxxxxxxx>

Good catch, thank you!

I have queued this on -rcu, and it will become visible on kernel.org
on my next rebase. Assuming good test results and no objections from
reviews, I will submit this not to the current merge window, but to
the next merge window (v5.20).

Thanx, Paul