Re: [PATCH] xfs: drop the useless LIST_HEAD in __mtd_del_partition()

[Miquel Raynal]

Hi Haowen,

baihaowen@xxxxxxxxx wrote on Fri, 27 May 2022 18:01:18 +0800:

> Drop LIST_HEAD where the variable it declares is never used.
> 
> Signed-off-by: Haowen Bai <baihaowen@xxxxxxxxx>

The title seems wrong. A fixes tag would be appropriate.

> ---
>  drivers/mtd/mtdpart.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mtd/mtdpart.c b/drivers/mtd/mtdpart.c
> index d442fa94c872..976e9c30244e 100644
> --- a/drivers/mtd/mtdpart.c
> +++ b/drivers/mtd/mtdpart.c
> @@ -326,7 +326,6 @@ static int __mtd_del_partition(struct mtd_info *mtd)
>  static int __del_mtd_partitions(struct mtd_info *mtd)
>  {
>  	struct mtd_info *child, *next;
> -	LIST_HEAD(tmp_list);
>  	int ret, err = 0;
>  
>  	list_for_each_entry_safe(child, next, &mtd->partitions, part.node) {


Thanks,
Miquèl