Re: mm: change huge_ptep_clear_flush() to return the original pte

From: Naresh Kamboju
Date: Thu May 26 2022 - 22:56:41 EST


Following build failures noticed on arm64 on Linux mainline tree.

Which was detected and discussed at this email thread.
https://lore.kernel.org/all/20220512193855.4f6ce32f@xxxxxxxxxxxxxxxx/T/

Reported-by: Linux Kernel Functional Testing <lkft@xxxxxxxxxx>

Build errors:
arch/arm64/mm/hugetlbpage.c: In function 'huge_ptep_clear_flush':
arch/arm64/mm/hugetlbpage.c:515:16: error: implicit declaration of
function 'get_clear_flush'; did you mean 'ptep_clear_flush'?
[-Werror=implicit-function-declaration]
515 | return get_clear_flush(vma->vm_mm, addr, ptep, pgsize, ncontig);
| ^~~~~~~~~~~~~~~
| ptep_clear_flush
arch/arm64/mm/hugetlbpage.c:515:16: error: incompatible types when
returning type 'int' but 'pte_t' was expected
515 | return get_clear_flush(vma->vm_mm, addr, ptep, pgsize, ncontig);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/mm/hugetlbpage.c:516:1: error: control reaches end of
non-void function [-Werror=return-type]
516 | }
| ^
cc1: some warnings being treated as errors

metadata:
git_repo: https://gitlab.com/Linaro/lkft/mirrors/torvalds/linux-mainline
git_describe: v5.18-9901-g7f50d4dfe816
git_sha: 7f50d4dfe816dd916a7cbf39039674825c2b388b
git_short_log: 7f50d4dfe816 (\Merge tag 'for-linus' of
https://github.com/openrisc/linux\)
target_arch: arm64
toolchain: gcc-11


--
Linaro LKFT
https://lkft.linaro.org