Re: [PATCH] mm/hugetlb: Remove unnecessary huge_ptep_set_access_flags() in hugetlb_mcopy_atomic_pte()

From: Baolin Wang
Date: Thu May 26 2022 - 21:34:42 EST




On 5/26/2022 3:01 PM, Anshuman Khandual wrote:


On 5/25/22 15:56, Baolin Wang wrote:
There is no need to update the hugetlb access flags after just setting the
hugetlb page table entry by set_huge_pte_at(), since the page table entry
value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()

WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#9:
value has no changes. Thus remove the unnecessary huge_ptep_set_access_flags()

total: 0 errors, 1 warnings, 8 lines checked

Sure, will remove checkpatch warning in next verion.


in hugetlb_mcopy_atomic_pte().

Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>

Otherwise LGTM,

Reviewed-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>

Thanks. Also thanks to Muchun and Mike for reviewing.