Re: [PATCH] dt-bindings: PCI: apple: Add missing 'power-domains' property

From: Rob Herring
Date: Thu May 26 2022 - 17:45:57 EST


On Thu, May 26, 2022 at 03:48:15PM +0200, Sven Peter wrote:
> Hi,
>
>
> On Thu, May 26, 2022, at 03:41, Rob Herring wrote:
> > The 'unevaluatedProperties' schema checks is not fully working and doesn't
> > catch some cases where there's a $ref to another schema. A fix is pending,
> > but results in new warnings in examples.
> >
> > The Apple PCIe host has 3 power domains at least according to the example.
> > Add the 'power-domains' property to the schema.
> >
> > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > Ideally, we'd define what each power domain is, but I don't know what
> > they are.
> > ---
>
> I think the example is just wrong (or outdated) and we only need a single
> power-domain for pcie.
>
> The hierarchy is ps_pcie_ref -> ps_apcie -> ps_apcie_gp and the pcie
> node then only depends on ps_apcie_gp.

Okay, I'll update the example and schema.