Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

From: Linus Walleij
Date: Thu May 26 2022 - 16:08:17 EST


On Wed, May 25, 2022 at 3:36 PM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:
> On Mon, 23 May 2022 at 15:55, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:

> > Nope, failed:
> >
> > $ dim push-branch drm-misc-next
> > dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"):
> > Fixes: SHA1 in not pointing at an ancestor:
> > dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
> > dim: ERROR: issues in commits detected, aborting
> >
> > I don't know what to do with this, sorry. The other committers are maybe better
> > with this kind of situations. I think it is designed to stop me from
> > shooting myself
> > in the foot.
>
> Linus, can we get an ack from you (or anybody else from DRM core) to
> merge it through drm/msm tree?

Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> After a second thought, I think the patch contains wrong Fixes tag. It
> should be:
>
> Fixes: 1e0f66420b13 ("drm/display: Introduce a DRM display-helper module")
>
> With that in place would we be able to merge it through drm-misc? Does
> it needs to be resubmitted?

But it doesn't apply to drm-misc... that's my problem :/

Yours,
Linus Walleij