Re: [PATCH] workqueue: Fix type of cpu in trace event

From: Tejun Heo
Date: Thu May 26 2022 - 14:56:10 EST


On Tue, May 24, 2022 at 04:29:12PM -0400, Steven Rostedt wrote:
> On Wed, 4 May 2022 11:32:03 +0900
> Wonhyuk Yang <vvghjk1234@xxxxxxxxx> wrote:
>
> > The trace event "workqueue_queue_work" use unsigned int type for
> > req_cpu, cpu. This casue confusing cpu number like below log.
> >
> > $ cat /sys/kernel/debug/tracing/trace
> > cat-317 [001] ...: workqueue_queue_work: ... req_cpu=8192 cpu=4294967295
> >
> > So, change unsigned type to signed type in the trace event. After
> > applying this patch, cpu number will be printed as -1 instead of
> > 4294967295 as folllows.
> >
>
> I was going through my backlog of pending patches and came across this.
> Note, that trace events are maintained by the subsystem they belong to.
> This change is for workqueues, not tracing (as your subject correctly
> states).
>
> I Cc'd Tejun here as he maintains this code.

I'll apply it to the wq tree once rc1 drops.

Thanks.

--
tejun