Re: [PATCH 7/7] context_tracking: Always inline empty stubs

From: Mark Rutland
Date: Thu May 26 2022 - 11:11:05 EST


On Thu, May 26, 2022 at 08:02:06AM -0700, Josh Poimboeuf wrote:
> On Thu, May 26, 2022 at 12:52:59PM +0200, Peter Zijlstra wrote:
> > Because GCC is seriously challenged..
>
> Or are these CONFIG_DEBUG_SECTION_MISMATCH?

Does it matter?

The fact that CONFIG_DEBUG_SECTION_MISMATCH=y forces GCC to place these
out-of-line is really a debugging aid, since it shows us what it could
potentially leave out-of-line. It's not the *only* reason GCC might do this
(e.g. I see sanitizers and other debug options often have similar effects on
arm64).

So FWIW, for the patch:

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

... as I'd like this for arm64, even if you don't beleive that's necessary for
x86.

Thanks,
Mark.