Re: [RFC PATCH 07/14] media: camss: csiphy: Add support for 8x74

[Robert Foss]

On Sun, 22 May 2022 at 18:28, Luca Weiss <luca@xxxxxxxxx> wrote:
>
> From: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
>
> CSIPHY hardware modules in 8x74 and 8x16 are similar.
>
> Signed-off-by: Matti Lehtimäki <matti.lehtimaki@xxxxxxxxx>
> Signed-off-by: Luca Weiss <luca@xxxxxxxxx>
> ---
>  drivers/media/platform/qcom/camss/camss-csiphy.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c
> index 75fcfc627400..a0122705a874 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c
> @@ -557,7 +557,8 @@ int msm_csiphy_subdev_init(struct camss *camss,
>         csiphy->id = id;
>         csiphy->cfg.combo_mode = 0;
>
> -       if (camss->version == CAMSS_8x16) {
> +       if (camss->version == CAMSS_8x16 ||
> +                  camss->version == CAMSS_8x74) {

CHECK: Alignment should match open parenthesis
#27: FILE: drivers/media/platform/qcom/camss/camss-csiphy.c:561:
+    if (camss->version == CAMSS_8x16 ||
+           camss->version == CAMSS_8x74) {


>                 csiphy->ops = &csiphy_ops_2ph_1_0;
>                 csiphy->formats = csiphy_formats_8x16;
>                 csiphy->nformats = ARRAY_SIZE(csiphy_formats_8x16);
> @@ -582,6 +583,7 @@ int msm_csiphy_subdev_init(struct camss *camss,
>                 return PTR_ERR(csiphy->base);
>
>         if (camss->version == CAMSS_8x16 ||
> +           camss->version == CAMSS_8x74 ||
>             camss->version == CAMSS_8x96) {
>                 csiphy->base_clk_mux =
>                         devm_platform_ioremap_resource_byname(pdev, res->reg[1]);
> --
> 2.36.0
>

With that fixed:
Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>