Re: [PATCH] i2c: mediatek: Fix an error handling path in mtk_i2c_probe()

From: Qii Wang
Date: Thu May 26 2022 - 07:31:17 EST


On Sun, 2022-05-22 at 14:22 +0200, Christophe JAILLET wrote:
> The clsk are prepared, enabled, then disabled. So if an error occurs
> after
> the disable step, they are still prepared.
>
> Add an error handling path to unprepare the clks in such a case, as
> already
> done in the .remove function.
>
> Fixes: 8b4fc246c3ff ("i2c: mediatek: Optimize master_xfer() and avoid
> circular locking")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Qii Wang <qii.wang@xxxxxxxxxxxx>

> ---
> drivers/i2c/busses/i2c-mt65xx.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>