Re: [PATCH 0/2] bitops: __fls adjustments

From: Cezary Rojewski
Date: Thu May 26 2022 - 06:09:20 EST


On 2022-05-25 4:48 PM, Amadeusz Sławiński wrote:
Apparently on few architectures __fls is defined incorrectly. Fix this
by adjusting declarations to asm-generic ones.

As far as I can tell there should be no functional changes, but I don't
have devices to test it, so it was only compile tested.

Amadeusz Sławiński (2):
ARC: bitops: Change __fls to return unsigned long
m68k: bitops: Change __fls to return and accept unsigned long

arch/arc/include/asm/bitops.h | 2 +-
arch/m68k/include/asm/bitops.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)


Thanks for the fixes Amadeo!

I wonder if there are more places like this to address..
Not tested but I do not see any issues with the code so:

Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>


Regards,
Czarek