Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC

From: Brad Larson
Date: Wed May 25 2022 - 12:59:09 EST


Hi Krzysztof,

On Thu, Apr 7, 2022 at 11:59 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 07/04/2022 01:36, Brad Larson wrote:
> > Document the cadence qspi controller compatible for Pensando Elba SoC
> > boards. The Elba qspi fifo size is 1024.
> >

> > @@ -48,7 +49,7 @@ properties:
> > description:
> > Size of the data FIFO in words.
> > $ref: "/schemas/types.yaml#/definitions/uint32"
> > - enum: [ 128, 256 ]
> > + enum: [ 128, 256, 1024 ]
>
> Is 1024 valid for other controllers? If not, then probably this should
> be further constraint in allOf:if:then...

I'll change this to allOf:if:then so that the 1024 deep FIFO is
specific to Elba SoC.

Regards,
Brad