RE: [PATCH v4] scsi: storvsc: Removing Pre Win8 related logic

[Michael Kelley (LINUX)]

From: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx> Sent: Wednesday, May 25, 2022 4:27 AM
> 
> The latest storvsc code has already removed the support for windows 7 and
> earlier. There is still some code logic reamining which is there to support

s/reamining/remaining/

> pre Windows 8 OS. This patch removes these stale logic.
> This patch majorly does three things :
> 
> 1. Removes vmscsi_size_delta and its logic, as the vmscsi_request struct is
> same for all the OS post windows 8 there is no need of delta.
> 2. Simplify sense_buffer_size logic, as there is single buffer size for
> all the post windows 8 OS.
> 3. Embed the vmscsi_win8_extension structure inside the vmscsi_request,
> as there is no separate handling required for different OS.
> 
> Signed-off-by: Saurabh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>
> ---
> v4:
> * Removed sense_buffer_size variable and used STORVSC_SENSE_BUFFER_SIZE directly
> in all places
> * Removed the comment along with sense_buffer_size and placed a more simpler
> comment for STORVSC_SENSE_BUFFER_SIZE
> * Added back WIN6 and WIN7 protocol version macros
> 
>  drivers/scsi/storvsc_drv.c | 155 ++++++++++---------------------------
>  1 file changed, 39 insertions(+), 116 deletions(-)

Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>