Re: [PATCH v7 1/1] firmware: mediatek: add adsp ipc protocol interface

[AngeloGioacchino Del Regno]

Il 25/05/22 12:39, AngeloGioacchino Del Regno ha scritto:
> Il 07/04/22 15:03, Allen-KH Cheng ha scritto:
> > From: Allen-KH Cheng <Allen-KH.Cheng@xxxxxxxxxxxx>
> >
> > Some of mediatek processors contain
> > the Tensilica HiFix DSP for audio processing.
> >
> > The communication between Host CPU and DSP firmware is
> > taking place using a shared memory area for message passing.
> >
> > ADSP IPC protocol offers (send/recv) interfaces using
> > mediatek-mailbox APIs.
> >
> > We use two mbox channels to implement a request-reply protocol.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@xxxxxxxxxxxx>
> > Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > Reviewed-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>
> > Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
> > Reviewed-by: YC Hung <yc.hung@xxxxxxxxxxxx>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> > ---
> >   drivers/firmware/Kconfig                      |   1 +
> >   drivers/firmware/Makefile                     |   1 +
> >   drivers/firmware/mediatek/Kconfig             |   9 +
> >   drivers/firmware/mediatek/Makefile            |   2 +
> >   drivers/firmware/mediatek/mtk-adsp-ipc.c      | 161 ++++++++++++++++++
> >   .../linux/firmware/mediatek/mtk-adsp-ipc.h    |  65 +++++++
> >   6 files changed, 239 insertions(+)
> >   create mode 100644 drivers/firmware/mediatek/Kconfig
> >   create mode 100644 drivers/firmware/mediatek/Makefile
> >   create mode 100644 drivers/firmware/mediatek/mtk-adsp-ipc.c
> >   create mode 100644 include/linux/firmware/mediatek/mtk-adsp-ipc.h
>
> Gentle ping for this one, as it's getting stale... and it's ready.
>
> To add context, this driver is *really* necessary, as support for it
> is added in the MT8195 ASoC SOF driver as a platform device [1], and the
> necessary memory regions are coming from the mediatek,mt8195-dsp [2] driver.
>
> [1]: 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/sound/soc/sof/mediatek/mt8195/mt8195.c?h=next-20220525#n389 
>
>
> [2]: 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml?h=next-20220525#n61 
>
>
> Cheers,
> Angelo


I'm sorry, ignore me, another version of this one was already merged.