Re: [PATCH] iio: srf08: Remove redundant if statement

From: Andreas Klinger
Date: Wed May 25 2022 - 02:34:16 EST


Acked-by: Andreas Klinger <ak@xxxxxxxxxxxxx>

Li Zhengyu <lizhengyu3@xxxxxxxxxx> schrieb am Mo, 23. Mai 20:27:
> (!val) has been checked outside the loop, remove redundant (val &&)
> from loop.
>
> Signed-off-by: Li Zhengyu <lizhengyu3@xxxxxxxxxx>
> ---
> drivers/iio/proximity/srf08.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index ac1ab7e89d4e..7ed11339c31e 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data,
> return -EINVAL;
>
> for (i = 0; i < data->chip_info->num_sensitivity_avail; i++)
> - if (val && (val == data->chip_info->sensitivity_avail[i])) {
> + if (val == data->chip_info->sensitivity_avail[i]) {
> regval = i;
> break;
> }
> --
> 2.17.1
>

--
Andreas Klinger
Grabenreith 27
84508 Burgkirchen
+49 8623 919966
ak@xxxxxxxxxxxxx
www.it-klinger.de
www.grabenreith.de