Re: [PATCH v7 03/10] iommu/sva: Add iommu_sva_domain support

[Baolu Lu]

Hi Jason,

On 2022/5/24 21:44, Jason Gunthorpe wrote:
> > diff --git a/drivers/iommu/iommu-sva-lib.c b/drivers/iommu/iommu-sva-lib.c
> > index 106506143896..210c376f6043 100644
> > +++ b/drivers/iommu/iommu-sva-lib.c
> > @@ -69,3 +69,51 @@ struct mm_struct *iommu_sva_find(ioasid_t pasid)
> >   	return ioasid_find(&iommu_sva_pasid, pasid, __mmget_not_zero);
> >   }
> >   EXPORT_SYMBOL_GPL(iommu_sva_find);
> > +
> > +/*
> > + * IOMMU SVA driver-oriented interfaces
> > + */
> > +struct iommu_domain *
> > +iommu_sva_alloc_domain(struct bus_type *bus, struct mm_struct *mm)
> This should return the proper type

Can you please elaborate a bit on "return the proper type"? Did you mean
return iommu_sva_domain instead? That's a wrapper of iommu_domain and
only for iommu internal usage.

Best regards,
baolu