Re: [PATCH v11 3/3] drm/msm/dp: delete vdda regulator related functions from eDP/DP controller

From: Doug Anderson
Date: Tue May 24 2022 - 20:21:00 EST


Hi,

On Fri, May 20, 2022 at 2:27 PM Kuogee Hsieh <quic_khsieh@xxxxxxxxxxx> wrote:
>
> @@ -101,11 +101,6 @@ struct dp_reg_entry {
> int disable_load;
> };
>
> -struct dp_regulator_cfg {
> - int num;
> - struct dp_reg_entry regs[DP_DEV_REGULATOR_MAX];

You forgot to delete the #define of DP_DEV_REGULATOR_MAX earlier in this file.

Other than that, this looks good to me.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>