On 23/5/22 18:03, Michael Walle wrote:
According to JEP106BC the vendor code 0x25 is Tristar. I'm
not sure what is going on here.
Nor I! The board schematic[0] reports the use of GD25LQ128EWIGR
(vendor Gigadevices), but indeed the chip itself reports vendor
Tristar.
I will ask the community/vendor about this discrepancy.
This flash supports SFDP, please provide an SFDP dump, see [1].
I will include this in my v2 patch. For posterity, here's the dump:
$ xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
53464450060101ff00060110300000ff9d05010380000002ffffffffffff
ffffffffffffffffffffffffffffffffffffe520f9ffffffff0744eb086b
083b80bbfeffffffffff00ffffff44eb0c200f5210d800ff234ac90082d8
11c7cccd68467a757a75f7a2d55c4a422cfff030c080ffffffffffffffff
ffffffffffffffff501950169cf9c0648fecffff
$ md5sum /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
de4d6be54e479d60859b0ca8a0ee9216 /sys/bus/spi/devices/spi0.0/spi-nor/sfdp
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/jedec_id
257018
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/partname
gd25lq128e
$ cat /sys/bus/spi/devices/spi0.0/spi-nor/manufacturer
gigadevice
I have attached the parsed sfdp, according to
https://github.com/petris/sfdp-parser
Did you test locking?
No. The datasheet mentions Status Register locking, but I will look
into how to adequately test this.
As this flash supports SFDP, please use SNOR_ID3(0x257018)
and drop both the INFO() and the NO_SFDP_FLAGS(). You'll
need my SNOR_ID3() patches [2].
SGTM, will do.