Re: [PATCH] MIPS: Rewrite `csum_tcpudp_nofold' in plain C
From: Florian Fainelli
Date: Tue May 24 2022 - 14:31:04 EST
On 5/24/22 10:18, Maciej W. Rozycki wrote:
On Tue, 24 May 2022, Florian Fainelli wrote:
I have visually inspected code produced and verified this change to boot
with TCP networking performing just fine, both with a 32-bit and a 64-bit
configuration. Sadly with the little endianness only, because in the
course of this verification I have discovered the core card of my Malta
board bit the dust a few days ago, apparently in a permanent manner, and I
have no other big-endian MIPS system available here to try.
How about QEMU is not that a viable option for testing big/little endian
configurations?
Yeah, for this particular change, sure. I don't have QEMU set up however
at the moment and would have to take some time to sort it, and it won't do
for peripherals it doesn't implement. The failure is a fresh problem and
I yet need to figure out what to do about it. A bad coincidence I guess
as I have MIPS hardware 10 years older that still goes strong.
If that makes it any easier, OpenWrt has 4 configurations of Malta for
QEMU which allows you to have at least networking (relevant here) for
32/64 and le/be:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=tree;f=target/linux/malta;h=90b2913dec291a1926eefc332b90b5842746c6e6;hb=HEAD
Along with a readme file on how to start those platforms:
https://git.openwrt.org/?p=openwrt/openwrt.git;a=blob;f=target/linux/malta/README;h=bbe806de3d6671d69ecc3db0fcfccf9f9176de13;hb=HEAD
It's really easy.
--
Florian