Re: [PATCH 1/2] leds: Add driver for Qualcomm LPG

[Marijn Suijten]

On 2022-05-24 00:18:35, Pavel Machek wrote:
[...]
> > > I'd really like to see the patch fixing the pattern interface (or
> > > disabling it). I don't want to push the tree to Linus with that bug.
> > 
> > (I couldn't help but be confused for a minute by this being a reply to
> > the original v1 patchset from March 2017 :) )
> > 
> > Does that mean there's still some time to review / pick up [1]
> > (LPG enablement for PM660L)?  And even more so for [2] (fixing the use
> > of a software-pattern variable in the hardware-pattern code) which
> > complements Bjorn's series but hasn't been looked at ever since last
> > year.
> 
> There's still time if the patches are perfect.

How should I know if a patch is perfect when it has been ignored for
over a year [1]?  Only Bjorn has reviewed and tested it.

I'm not asking for an instant merge, but feedback is appreciated.  I
don't see any glaring issues with the patch so I'm kindly (re-)asking
you to point them out so that I can correct the patch.

- Marijn

[1]: https://lore.kernel.org/linux-leds/20210418213427.220638-1-marijn.suijten@xxxxxxxxxxxxxx/