RE: [PATCH net-next v3] drivers, ixgbe: export vf statistics

From: Jankowski, Konrad0
Date: Tue May 24 2022 - 11:53:32 EST




> -----Original Message-----
> From: Maximilian Heyne <mheyne@xxxxxxxxx>
> Sent: Monday, May 9, 2022 1:04 PM
> Cc: Maximilian Heyne <mheyne@xxxxxxxxx>; Brandeburg, Jesse
> <jesse.brandeburg@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric
> Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo
> Abeni <pabeni@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH net-next v3] drivers, ixgbe: export vf statistics
>
> This change retrieves network metrics for virtual functions from the device
> and exports them via the iproute2 interface.
>
> The code for retrieving the statistics from the device is taken from the out-of-
> tree driver. The feature was introduced with version 2.0.75.7, so the diff
> between this version and the previous version 2.0.72.4 was used to identify
> required changes. The export via ethtool is omitted in favor of using the
> standard ndo_get_vf_stats interface.
>
> Per-VF statistics can now be printed, for instance, via
>
> ip --statistics link show dev eth0
>
> Signed-off-by: Maximilian Heyne <mheyne@xxxxxxxxx>
> ---
> v2: implemented the ndo_get_vf_stats callback
> v3: as per discussion, removed the ethtool changes
>
> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 34 ++++++++
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 86 +++++++++++++++++++
> drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 7 ++
> 3 files changed, 127 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> index 921a4d977d65..48444ab9e0b1 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
>

Tested-by: Konrad Jankowski <konrad0.jankowski@xxxxxxxxx>