Re: [PATCH] efi: EFI_DISABLE_RUNTIME should depend on EFI

From: Geert Uytterhoeven
Date: Tue May 24 2022 - 03:36:34 EST


Hi Javier,

On Tue, May 24, 2022 at 9:22 AM Javier Martinez Canillas
<javierm@xxxxxxxxxx> wrote:
> On 5/24/22 08:54, Geert Uytterhoeven wrote:
> > The EFI_DISABLE_RUNTIME config option controls the use of Extensible
> > Firmware Interface (EFI) runtime services, which matters only if EFI
> > support is enabled.
> >
>
> Indeed. Sorry for forgetting that dependency when adding the symbol.
>
> > Hence add a dependency on EFI, to prevent asking the user about this
> > control knob when configuring a kernel with EFI support.
> >
>
> I think you wanted to write here "without EFI support" ?

Oops, sorry for that. Need... morning... coffee...

> > Fixes: a031651ff2144a3d ("efi: Allow to enable EFI runtime services by default on RT")
> > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
>
> Acked-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds