Re: [PATCH 1/4] dt-bindings: usb: mtk-xhci: add support 'resets' property

From: Chunfeng Yun
Date: Mon May 23 2022 - 23:03:12 EST


Hi Rex-BC,

On Mon, 2022-05-23 at 18:41 +0800, Rex-BC Chen wrote:
> On Mon, 2022-05-23 at 17:04 +0800, Chunfeng Yun wrote:
> > Add 'resets' property to support IP reset usually by top pericfg.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@xxxxxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml | 3
> > +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-
> > xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-
> > xhci.yaml
> > index 084d7135b2d9..892718459d25 100644
> > --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml
> > @@ -113,6 +113,9 @@ properties:
> > vbus-supply:
> > description: Regulator of USB VBUS5v
> >
> > + resets:
> > + maxItems: 1
> > +
> > usb3-lpm-capable: true
> >
> > usb2-lpm-disable: true
>
> Hello Chunfeng,
>
> Which soc we will use this reset?
This is common for all SoCs, can use it if there is a reset controller
driver supported.

> I am upstreaming another series for system clock reset.
That's good
> I think you should add how to use for this series base on [1].
Currently I test it on mt8195 based on ti-syscon reset driver, luckly
this is transparent for our usb controller drivers;

I could add patches to use this 'resets' property on mt8195/8186 if the
below series are applied.

Thanks

>
> [1]:
>
https://lore.kernel.org/linux-clk/5067ec46-7a82-6b7b-5b07-3102cfaefbf6@xxxxxxxxxxxxx/T/#m5b6abb9bd2109e4ed9a1a3eeee6e7976892cb8c2
>
> BRs,
> Rex
>