Re: [PATCH v2 1/2] arm64: dts: qcom: sc7280: herobrine: Don't disable the keyboard backlight node

From: Doug Anderson
Date: Mon May 23 2022 - 16:12:41 EST


Hi,

On Mon, May 23, 2022 at 12:32 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> On herobrine boards the keyboard backlight is controlled through the
> PWM LED driver. Currently both the PWM LED node and the node for the
> keyboard backlight are disabled in sc7280-herobrine.dtsi, which
> requires boards with a backlit keyboard to enable both nodes. There
> are no other PWM LEDs on herobrine boards besides the keyboard
> backlight, delete the 'disabled' status from the keyboard backlight
> node, with that boards only have to enable the 'pwmleds' node for
> keyboard backlight support.
>
> Also add a label to the 'pwmleds' node to allow board files to refer to
> it with a phandle.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
>
> (no changes since v1)
>
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>