Re: [PATCH v5.10] staging: rtl8723bs: prevent ->Ssid overflow in rtw_wx_set_scan()

From: Denis Efremov
Date: Mon May 23 2022 - 14:18:52 EST


Hi,

On 5/23/22 19:26, Greg KH wrote:
> On Fri, May 20, 2022 at 07:57:30AM +0400, Denis Efremov (Oracle) wrote:
>> This code has a check to prevent read overflow but it needs another
>> check to prevent writing beyond the end of the ->Ssid[] array.
>>
>> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
>> Cc: stable <stable@xxxxxxxxxxxxxxx>
>> Signed-off-by: Denis Efremov (Oracle) <efremov@xxxxxxxxx>
>> ---
>> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> And only 5.10 needs this? What about all other kernel branches?
>

>From 5.10, 5.4, 4.19, to 4.14.

There is a small spaces conflict in 5.4-4.14 kernels because of
c77761d660a6 staging: rtl8723bs: Fix spacing issues

I sent another patch to handle it.

Thanks,
Denis